search

ash-jc-allen / short-url

A Laravel package for creating shortened URLs for your web apps.
MIT License
1.27k stars 162 forks source link

Fix collision and performance issue #213

Closed hari closed 1 year ago

hari commented 1 year ago

Closes #210

hari commented 1 year ago

@ash-jc-allen This one needs your review 😊. All tests are passing. I don't think I need to add any extra tests.

ash-jc-allen commented 1 year ago

Hey @hari! Apologies for the delay in getting this merged (it's been a busy few weeks!). Huge thank you 😄

boris-glumpler commented 1 year ago

Hey @ash-jc-allen, did you see my comment above? Came across this same issue with another package a while ago and their migrations threw an error for me because this particular collation doesn't exist on Postgres, which is case-sensitive by default.

ash-jc-allen commented 1 year ago

Hey @boris-glumpler! I can't see any comments from you on this page, sorry. This is all I see:

image

I wonder if the comment might be part of a "review" that's not been submitted yet, maybe?

Thanks for pointing this out to me. I've not got any experience with using Postgres, so I wasn't aware of that. I'll make sure to update the readme to mention that you might want to remove this part of the migration if you're using Postgres 🙂

boris-glumpler commented 1 year ago

Duh... You should be able to see it now ;)