ash-jc-allen / short-url

A Laravel package for creating shortened URLs for your web apps.
MIT License
1.27k stars 161 forks source link

poc using foroco/php-browser-detection #249

Closed marzvrover closed 6 months ago

marzvrover commented 7 months ago

This is a simple proof-of-concept using foroco/php-browser-detection instead of jenssegers/agent to fix https://github.com/ash-jc-allen/short-url/issues/227. Added as a draft because while setting up foroco/php-browser-detection I noticed a few things:

I am opening this draft PR to show the places requiring updates when looking into other UA parsers/knowledge bases such as donatj/PhpUserAgent

ash-jc-allen commented 6 months ago

Hey @marzvrover! I'm really sorry for taking so long to come back to this. I'm going to close this PR in favour of your changes in #250 which I've piggy backed off. I'll leave another comment on that PR with more details 😄