Function atomic_ref/1 not found when doing a create with upsert?: true

[adonig]

Describe the bug My create action raises this error during while doing an upsert:

    ** (KeyError) key :atomic_validations not found in: {:not_atomic,
 "Failed to validate expression if hash != atomic_ref(hash) do\n  now()\nelse\n  updated_at\nend: %Ash.Error.Query.NoSuchFunction{function: :atomic_ref, arity: nil, resource: Apix.Catalog.Product, splode: nil, bread_crumbs: [], vars: [], path: [], stacktrace: #Splode.Stacktrace<>, class: :invalid}"}

To Reproduce Tried to do this in a create action that supports upsert:

      change atomic_update(
               :changed_at,
               expr(
                 if hash != atomic_ref(hash) do
                   now()
                 else
                   changed_at
                 end
               )
             )

Expected behavior It shouldn't raise an exception. Instead it should set changed_at to now() iff the hash changed.

Runtime

• 1.17.2-otp-27
• 27.0.1
• Fedora Workstation 40
• 3.4.1
• ash_postgres 2.2.0

Additional context See #debugging Discord channel.

[zachdaniel]

@adonig I didn't spot this when I asked you to open a bug, but the problem is just one of syntax.

atomic_ref is a template like actor or arg

      change atomic_update(
               :changed_at,
               expr(
                 if hash != ^atomic_ref(:hash) do
                   now()
                 else
                   changed_at
                 end
               )
             )

[adonig]

Thank you! I believe we have to update the docs accordingly:

changes do
  change atomic_update(:slug, expr(fragment("slugify(?)", atomic_ref(:name)))), where: changing(:name), on: [:update]
end

I will create a PR for it.