ash-project / ash

A declarative, extensible framework for building Elixir applications.
https://www.ash-hq.org
MIT License
1.63k stars 216 forks source link

Typo relating to no_filter_static_forbidden_reads? #1436

Closed ahey closed 2 months ago

ahey commented 2 months ago

With the recently added no_filter_static_forbidden_reads? option, we have:

Keyword.get(
  Application.get_env(:ash, :policy, []),
  :no_filter_static_forbidden_reads?,
  true
)

However, the getting started guide instructs to add:

config :ash, :policies, no_filter_static_forbidden_reads?: false

We should either change the former code from policy to policies, or the latter from policies to policy. I didn't know which way round it should be so have not submitted a PR.

zachdaniel commented 2 months ago

Oops 🤦 , thanks for pointing this out. I'll cut a new release with this using the correct configuration.