Open juhalehtonen opened 1 year ago
Added three more UI tweaks to the list:
For button styled to look like a text field, that was inspired by how they do it on tailwindcss, will probably keep it that way.
As for removing the ash core package, it should still display as present, interestingly, because whenever you're viewing a guide from a specific package (i.e if you were linked there) we include it in the selected packages (temporarily, i.e if you leave the sidebar would change). Its kind of a weird system though.
I'd like to add a few things that I noticed in the same vein as those that @juhalehtonen suggested. If preferable, I'd be happy to create a new issue for this, but it seems like this issue could perhaps just become a catch-all for these sorts of minor UI enhancements/tweaks.
I'd also like to add a 👍 to "Mobile UI: floating menu doesn't close when loading new content" -- it was on my list as well.
Addressed a fair amount of these. Realistically I've addressed all of them that I personally will (or checked them off because they are working as intended), but others are more than welcome to take the remaining items :D
Thanks @zachallaun for pointing these ones out. I've added your points to the description of the issue to help keep them from being forgotten.
For future reference, one sample page where the scroll-hijacking is very visible is https://ash-hq.org/docs/module/ash/2.2.0/ash-resource-info .
I whipped up a quick-and-ugly CSS demo on how we could address the two points of:
Essentially the main points here are the order
properties (to ensure in-page search finds content first) and avoiding any overflow-hiding techniques, allowing the body to pass the browser scrolling to the main content.
Not quite sure how to apply these ideas to the existing Tailwind classes though, so perhaps someone more well versed with that framework can figure that one out 🙂
Perhaps an issue is not the best place to gather these, so please feel free to move elsewhere. I wanted to compile these somewhere so that they can be addressed one way or the other.
Observing the site, I came up with the following list of small items that could possibly be tweaked: