ash-project / ash_hq

The Ash Framework homepage and documentation site.
MIT License
48 stars 26 forks source link

List bullets in table of contents don't render in Safari #96

Open sevenseacat opened 1 year ago

sevenseacat commented 1 year ago

Brief Description

When adding the necessary classes to make the text overflow “…” work, it makes the list bullets (both numbers and alphas) disappear in Safari only, both web and mobile.

Steps to reproduce the bug

Visit any page with a table of contents, eg. https://ash-hq.org/docs/guides/ash/latest/tutorials/get-started

In Firefox/Chrome the list markers appear, but in Safari they do not.

Context

Screenshot 2023-02-13 at 11 11 52 am
sevenseacat commented 1 year ago

The HTML used in this table of contents is generated here -> https://github.com/ash-project/ash_hq/blob/main/lib/ash_hq/docs/extensions/render_markdown/post_processors/table_of_contents_generator.ex

So any fix to this will probably tweaking what classes get added to the li elements, both first and second levels, on both https://github.com/ash-project/ash_hq/blob/b00d56b5c236f695d52a54a5b742a8bcb555dbd8/lib/ash_hq/docs/extensions/render_markdown/post_processors/table_of_contents_generator.ex#L38 and https://github.com/ash-project/ash_hq/blob/b00d56b5c236f695d52a54a5b742a8bcb555dbd8/lib/ash_hq/docs/extensions/render_markdown/post_processors/table_of_contents_generator.ex#L102 .

Any new classes that get added may need to also be added to the Tailwind config in tailwind.config.js, as they will be stored as part of the database content and not part of the application UI code.