feat: open_api options in Api

ash-project / ash_json_api

The JSON:API extension for the Ash Framework

https://hexdocs.pm/ash_json_api

MIT License

56 stars 40 forks source link

feat: open_api options in Api #104

Closed deviprsd closed 11 months ago

deviprsd commented 11 months ago

fixes #103

Contributor checklist

[ ] Bug fixes include regression tests
[ ] Features include unit/acceptance tests

zachdaniel commented 11 months ago

Looks great! Had some feedback, but otherwise very pleased :)

deviprsd commented 11 months ago

@zachdaniel I can't figure out why the verifier isn't working, how does one test it? Dialyzer also keeps throwing Undefined callback function verify/1 but I have implemented it 🤷🏾

deviprsd commented 11 months ago

Still don't get the error but dialyzer has stopped complaining

deviprsd commented 11 months ago

Ok, I'm getting the error now but how does one make sure it shows up in the editor instead of terminal like the nimble options validator?

zachdaniel commented 11 months ago

We don't currently have a way for errors in verifiers/transformers to target file/line metadata unfortunately.

deviprsd commented 11 months ago

I'm not sure why dialyzer is failing and two other tests. I don't believe I changed anything in them