search

ash-project / ash_json_api

The JSON:API extension for the Ash Framework
https://hexdocs.pm/ash_json_api
MIT License
56 stars 40 forks source link

Pagination links problems #115

Closed mrdotb closed 6 months ago

mrdotb commented 6 months ago

Contributor checklist

:wave:

I found two issues:

  1. The request.json_api_prefix is not included in the generated links
  2. the path seems to work on test here but when using on my project my links are bare url the following code modification seems to fix the issue.

I feel like the pagination testing can be less redundant. Not sure if there is a better way to test the presence of the json_api_prefix on pagination links.

mrdotb commented 6 months ago

Duplicate of #108. fixed in https://github.com/ash-project/ash_json_api/commit/c9993777b4bc71f250fb542b2ba18961a397554e