ash-project / ash_json_api

The JSON:API extension for the Ash Framework
https://hexdocs.pm/ash_json_api
MIT License
55 stars 41 forks source link

Don't require update action on embedded if no update routes are present #197

Closed rbino closed 4 weeks ago

rbino commented 4 weeks ago

Describe the bug After 7e25b92b8bf78b22 we had a small regression where we add an :update action to an embedded resource that was used as an argument even if the parent resource only had a single route with a :create action (so it was never used in :update actions via JSON:API)

Expected behavior Update actions should be required (and their doc generated) only if they are actually used

zachdaniel commented 4 weeks ago

What happens in that case? Do you get an error?