ash-project / ash_json_api

The JSON:API extension for the Ash Framework
https://hexdocs.pm/ash_json_api
MIT License
63 stars 43 forks source link

Igniter tasks don't wrap modules in `Module.concat` hack when adding to domain #213

Closed sevenseacat closed 4 months ago

sevenseacat commented 4 months ago

Describe the bug

Not technically a bug, but behaviour changed from existing documentation. Currently we say this for manual installs:

Screenshot 2024-07-27 at 1 38 14 AM

But when we add domains to a JsonApiRouter via an igniter like ash.patch.extend, we don't have the Module.concat hack in place, it lists the domains normally.

Update: lib/cat_web/ash_json_api_router.ex

1 1   |defmodule CatWeb.AshJsonApiRouter do
2 2   |  use AshJsonApi.Router,
3   - |    domains: [],
  3 + |    domains: [Cat.Food],
4 4   |    open_api: "/open_api"
5 5   |end
   ...|

Runtime

zachdaniel commented 4 months ago

Fixed in f4a4f301ea61b51dba7b9f61ef8ae1b90ccaffcf