feat: support `required` in belongs_to relationship

ash-project / ash_json_api

The JSON:API extension for the Ash Framework

https://hexdocs.pm/ash_json_api

MIT License

56 stars 40 forks source link

feat: support `required` in belongs_to relationship #41

Closed transhapHigsn closed 3 years ago

transhapHigsn commented 3 years ago

Contributor checklist

[x] My commit messages follow the Conventional Commit Message Format For example: fix: Multiply by appropriate coefficient, or feat(Calculator): Correctly preserve history Any explanation or long form information in your commit message should be in a separate paragraph, separated by a blank line from the primary message
[ ] Bug fixes include regression tests
[x] Features include unit/acceptance tests

transhapHigsn commented 3 years ago

Test cases not completed yet.

transhapHigsn commented 3 years ago

Changes for issue #38

zachdaniel commented 3 years ago

The changes look great, added a comment on the implementation. Two things: 1.) we'll want to remove the mix.lock changes, and 2.) need to add some tests.

Then it is good to go! Great job 👍

transhapHigsn commented 3 years ago

@zachdaniel yeah will do that.