feat: Add JsonPrimaryKey to support customizing the primary key

ash-project / ash_json_api

The JSON:API extension for the Ash Framework

https://hexdocs.pm/ash_json_api

MIT License

56 stars 40 forks source link

Closed mangeption closed 3 years ago

mangeption commented 3 years ago

[x] My commit messages follow the Conventional Commit Message Format For example: fix: Multiply by appropriate coefficient, or feat(Calculator): Correctly preserve history Any explanation or long form information in your commit message should be in a separate paragraph, separated by a blank line from the primary message
[ ] Bug fixes include regression tests
[x] Features include unit/acceptance tests

zachdaniel commented 3 years ago

Had a few comments, but overall this looks great! Awesome work.

As for testing the DSL validations, you can actually run compile time code in the tests, e.g

test "foo" do
  assert_raise Ash.Error.Dsl.DslError, ~r/match/, fn -> 
    defmodule BadResource do
       .....
    end
  end
end

zachdaniel commented 3 years ago

Great work!

🚀 Thank you for your contribution! 🚀