fix!: Status should be a string from json:api documentation

ash-project / ash_json_api

The JSON:API extension for the Ash Framework

https://hexdocs.pm/ash_json_api

MIT License

62 stars 42 forks source link

fix!: Status should be a string from json:api documentation #67

Closed franckstifler closed 1 year ago

franckstifler commented 1 year ago

Currently on error responses the library returns a status key which is a string, violating the specification as mentioned here: https://jsonapi.org/format/#error-objects

Contributor checklist

[ ] Bug fixes include regression tests
[ ] Features include unit/acceptance tests

zachdaniel commented 1 year ago

Yep, looks like an oversight on our part. This could break the workflow for users using ash_json_api, but I believe spec non-compliance takes priority. Will release as a minor version bump since we are pre 1.0

🚀 Thank you for your contribution! 🚀