improvement: added route default_fields with test

ash-project / ash_json_api

The JSON:API extension for the Ash Framework

https://hexdocs.pm/ash_json_api

MIT License

62 stars 42 forks source link

improvement: added route default_fields with test #76

Closed tommasop closed 1 year ago

tommasop commented 1 year ago

PR linked to this discussion: https://discord.com/channels/711271361523351632/1091730040699506750

Added minimal testing

zachdaniel commented 1 year ago

Looks great! Got some format/credo stuff to address. One of the mix test is going fail no matter what though, thats not your fault.

tommasop commented 1 year ago

Should have fixed the formatting issues, for the credo part l'll leave it up to you if you want to refactor the serialize_attributes function or please give me some guidance :)

zachdaniel commented 1 year ago

There are some failing tests, see the test task ending in (false, false)

tommasop commented 1 year ago

Done, thanks for your patience :)

zachdaniel commented 1 year ago

🚀 Thank you for your contribution! 🚀