search

ash-project / ash_paper_trail

The extension for keeping an audit log of changes to your Ash resources.
https://hexdocs.pm/ash_paper_trail
MIT License
32 stars 15 forks source link

Changes attribute should be sensitive #22

Closed rgraff closed 1 year ago

rgraff commented 1 year ago

Since the changes attribute could include sensitive attributes, it should itself be sensitive.

Should it also be private?

zachdaniel commented 1 year ago

Hmm...probably all attributes should be private, except for explicitly configured public ones?

zachdaniel commented 1 year ago

And yes they should be similarly sensitive

rgraff commented 1 year ago

The attributes_as_attributes copy their sensitive and private options. I think that's good for now.