ash-project / ash_postgres

The PostgreSQL data layer for Ash Framework
https://hexdocs.pm/ash_postgres
MIT License
134 stars 73 forks source link

fix: check for existing installed_extensions/0 in ash_postgres.install #338

Closed ibarakaiev closed 2 months ago

ibarakaiev commented 2 months ago

Contributor checklist

This is a minor improvement that checks whether installed_extensions/0 already exists in the repo module before adding it. This is only an issue when an igniter installer is run twice, but I faced it once so just thought it'd be great to catch it.

ibarakaiev commented 2 months ago

I'm not able to reproduce the failing job locally :thinking:.

zachdaniel commented 2 months ago

It looks to do the right thing, will be testing the full flow before we release 👍

zachdaniel commented 2 months ago

🚀 Thank you for your contribution! 🚀