search

ash-project / ash_sql

A library containing some shared Ecto-based sql data layer functionality.
MIT License
4 stars 8 forks source link

fix: use SQL standard = instead of non standard == #28

Closed lejoko closed 4 months ago

lejoko commented 4 months ago

Currently, some dynamic expressions (with || and &&) build non-standard SQL that uses == FALSE instead of = FALSE. MySQL does not support that and therefore I need that fix for my preliminary ash_mysql module (https://github.com/lejoko/ash_mysql). I would have happily added tests, but there are no tests at all in ash_sql... I manually tested those change both with ash_postgres and ash_sqlite and their tests seem fine with it.

zachdaniel commented 4 months ago

🚀 Thank you for your contribution! 🚀