fix: :error consistency in remove_keyword_key and argument_equals? in Config.configure

ash-project / igniter

A code generation and project patching framework.

https://hexdocs.pm/igniter/readme.html

MIT License

155 stars 20 forks source link

fix: :error consistency in remove_keyword_key and argument_equals? in Config.configure #68

Closed ibarakaiev closed 3 months ago

ibarakaiev commented 3 months ago

Contributor checklist

[ ] Bug fixes include regression tests
[ ] Features include unit/acceptance tests

This PR makes sure that Keyword.remove_keyword_key/2 always returns :error when it fails. It also modifies try_update_three_arg/5 and try_update_two_arg/5 to use argument_equals? for keys instead of argument_matches_pattern?.

zachdaniel commented 3 months ago

🚀 Thank you for your contribution! 🚀