search

ash-project / spark

Tooling for building DSLs in Elixir
MIT License
133 stars 26 forks source link

Remove Sections #52

Open zachdaniel opened 1 year ago

zachdaniel commented 1 year ago

Currently, sections don't really give us much, and ought to be replaceable with Entities.

We can shift our DSL builder to just use entities, and then we just import the top level entity. The only thing we need to support is a config on entities that repeated calls to it merge configs (like sections to).

joshprice commented 9 months ago

This would alleviate some confusion, it's hard to explain what the difference really is.

zachdaniel commented 9 months ago

Agreed. Unfortunately this would be a massive change that may never make the cut in terms of wether or not its worth it. But yeah it should have just been entities (i.e struct constructors) all the way down.