ash-project / spark

Tooling for building DSLs in Elixir
MIT License
127 stars 25 forks source link

chore: Add failing test for beam files with `?` in them. #67

Closed jimsynz closed 10 months ago

jimsynz commented 10 months ago

Related to https://github.com/ash-project/reactor/issues/75 - compiling on Windows will fail if the filename contains a question mark.

zachdaniel commented 10 months ago

So, I've merged this, but I'm partly wondering if this is an Elixir issue, not a spark issue. Or maybe kind of both? Specifically, that shouldn't be an allowed module name in Elixir if it doesn't work on windows.

zachdaniel commented 10 months ago

Otherwise, what should we do about this? Ensure our module names don't use question marks and replace it with QuestionMark or something?

zachdaniel commented 10 months ago

Okay, I did that last thing :)

jimsynz commented 10 months ago

So, I've merged this, but I'm partly wondering if this is an Elixir issue, not a spark issue. Or maybe kind of both? Specifically, that shouldn't be an allowed module name in Elixir if it doesn't work on windows.

Yeah, I was thinking the same thing. Maybe we should raise an issue with Elixir?

zachdaniel commented 10 months ago

Yeah, that would make sense. The trouble is the reproduction. I don't have a windows environment set up. But it should be pretty easy to make a test that does a bad defmodule and say "this will break on windows". Would you want to do that?

jimsynz commented 10 months ago

I don't have access to a windows machine either. Maybe @puruzio who raised the initial issue with Reactor may care to?

jimsynz commented 10 months ago

I can't wait for the bug report when someone is trying to define sections ending in ? and QuestionMark 🤣

zachdaniel commented 10 months ago

lol. Well, for any future person coming to this issue:

https://media.giphy.com/media/DRlN7T0IXTAqcgpd8S/giphy.gif

puruzio commented 9 months ago

I don't have access to a windows machine either. Maybe @puruzio who raised the initial issue with Reactor may care to?

Will do. Thanks!