search

ash-rs / ash

Vulkan bindings for Rust
Apache License 2.0
1.82k stars 186 forks source link

Don't check MSRV for ash-examples #874

Closed Friz64 closed 6 months ago

Friz64 commented 6 months ago

ash-examples has a lot of dependencies (mostly through winit), and so it's not unlikely for it to break the MSRV check. Here's the current CI error:

error: package `half v2.4.0` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.69.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p half@2.4.0 --precise ver
where `ver` is the latest version of `half` supporting rustc 1.69.0

It doesn't make much sense to have our MSRV influenced by it IMO.

MarijnS95 commented 6 months ago

Turns out I intended to land this via #799 in c3d2dd1e759fc9ca3995d0b872611a49c77d6526 too :)