search

ash-rs / ash

Vulkan bindings for Rust
Apache License 2.0
1.85k stars 188 forks source link

Still seeing "this function takes 4 arguments but 2 arguments were supplied" errors in Vulkan CI #962

Open oddhack opened 2 hours ago

oddhack commented 2 hours ago

ISTR talking about this but can't find the issue now - sorry if this is a dup. The problem with new attributes is gone - thanks! - but we're still seeing errors in ash-generate (gitlab) / build-test (Github) of form

error[E0061]: this function takes 4 arguments but 2 arguments were supplied 289
--> ash/src/extensions/amdx/shader_enqueue.rs:77:9

They seem to be confined to the one corresponding AMDX extension, which is interestingly weird.

MarijnS95 commented 2 hours ago

Hey yes, I just put an update in the latest issue that you filed, at https://github.com/ash-rs/ash/issues/959#issuecomment-2482782238:

After merging and re-running the CI code generation is once again successful, but compiling still fails because of #343 (comment), which I hope to solve entirely with #952 or at the very least fix in #951.

I probably need to discuss with @Ralith how we should design + release a fix for this in the near future. Perhaps I might just merge #951 to master and that should fix your immediate build issues.

That immediately preps us for the next breaking release, so I might be branching off at that point in case we want to aim for a nonbreaking release before this point.