search

ash47 / Frota

An addon for Dota 2, I intend for it to contain several sub game modes such as Legends of Dota and Random OMG
65 stars 73 forks source link

Add Frota Installer #155

Closed XavierCHN closed 10 years ago

XavierCHN commented 10 years ago

to copy frota to the correct path with a running dota2 client

ash47 commented 10 years ago

It looks like it would work, but I'm unfamiliar with vb script so I'll need to sit down and confirm it's not malicious, and verify that it does in fact work

XavierCHN commented 10 years ago

check https://github.com/XavierCHN/mFrotaInstaller for entire source code

ash47 commented 10 years ago

It seems ok to me, gonna get some opinions from other members of the project before I merge it.

madbyte commented 10 years ago

i couldn't test it, because something is missing in your github repo but is a form really needed? i created a frota downloader (https://github.com/madbyte/FrotaDownloader) as a console application and i guess it's everything that a user needs

and i saw that you use .net framework 4.5 "Note that the .NET Framework 4.5 is not supported on Windows XP." (http://msdn.microsoft.com/de-de/library/hh367887%28v=vs.110%29.aspx)

ash47 commented 10 years ago

Still walking about it on IRC, everyone who has commented on it so far, has said it is kind of pointless -- I'll consider linking to it -- but I don't really like the idea of distrubuting EXE files -- people are already concerned about being VAC banned...

ggassmann commented 10 years ago

Tested for linux with WINE, works fine. A native version would be greatly preferred.

XavierCHN commented 10 years ago

I'll try to make it work in both mac & lunix and send another pull request later