Closed ashToronto closed 4 months ago
I think the spinner for the PDF rendering works pretty well -
One thing of note I found in the accordion view was that depending on the order, the different elements (education, skills, etc) would be added to the accordion in different orders, compared to the standard order on the left hand side. I don't know if this is a big issue, but it seems a little inconsistent
this is easy enough to fix - i'll update - thanks for feedback
Looks mostly good. The only thing is that the order of the dropdowns does not reflect the order of the sections in the resume.
Though this may prove problematic because each resume has its own unique ordering of sections.
Possible solution: maybe include the pencil edit icon right next to the sections present on the left side of the resume edit screen (no dropdowns needed). Or, have the dropdowns be in the same order as the sections in the left side of the resume edit screen.
Yes there is reducdancy between the resume sidebar (creates a new section for work exp, education) and the accordian. The ultimate goal is to move each accordian section (they are all edit controller actions) into the same pages as the "create forms" i.e when you click on education sidebar it'll have the education edit accordian also - this way the user can both edit their existing sections and create a new one.
I will create a new ticket for this and go over the logic with you during our next pairing/grooming session.
I'm gonna go ahead and merge in cuz its will blocking my next ticket - the next ticket should address a lot of your pr comments :)
119
Updated resume show page to have an accordian view. This replaces the rendered cards and compliments the spacing taken up by the iframe:
I also got rid of the preview button as the iframe does that same functionality on page render.
We can further improve this layout in the future. it's meant to improve readability.
114
Add loading spinner alos - it stops loading when the iframe is fully loaded/rendered. Uses bootstrap spinner.