ashToronto / career_crafter_pro

A resume theming and career building web app
1 stars 0 forks source link

Refactor layouts resumes components #74

Closed ashToronto closed 2 weeks ago

ashToronto commented 2 weeks ago

Removes the partial/component based architecture in favor of less dry code. this is to reduce complexity and enhance code flexability. the component based approach will either force us to create deeply nested non-reusable components in our designs or come up with convention clashing component structures i.e horizontal contact info vs vertical contact info.

A better approach is to simply isolate the html/haml code into a single unique template associated to a wicked_pdf_stylesheet/css file which only serves that one resume template. This provides far greater design flexability and doesn't lock us into bre-building similar components with minor differences or "prop passing" deep into nested partials (performance issues will eventualy arise).

render[bot] commented 2 weeks ago

Your Render PR Server URL is https://career-crafter-pro-pr-74.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cprg8756l47c73e7puq0.