search

ashToronto / career_crafter_pro

A resume theming and career building web app
3 stars 1 forks source link

#78 just a bit of help to address pr fixes #91

Closed ashToronto closed 2 months ago

ashToronto commented 3 months ago

Great work for setting up the css and laying the foundation for this page. I felt the ticket might be frustrating you a bit so i decided to just lend a small hand and open this pr.

Notice that I removed all references of %div use this as a rule of thumb in haml - you will rarely need to set divs

I also just added some padding for the mobile responsive view and removed the card backgrounds for the text and logo.

I also only left 2 contributor cards, until the others actually do a ticket they won't be added.

mobile views:

Screenshot 2024-07-05 at 1 10 33 PM

contributor cards in mobile view - padding added:

Screenshot 2024-07-05 at 1 11 38 PM

ashToronto commented 3 months ago

I really appreciate it!

For feedback, the contributor and founder cards are a bit to wide for my liking and not tall enough (aiming of the dimensions in my figma mockup.

Sure sounds good - go for it - could you make the update directly in to this PR - updating height and width as you see fit. Also could you add yourself i.e linkedin, github, etc to the card. Once you do I'll add myself also. If you want to add some text into the card describing yourself/responsibilities go for it. Also claim a job title i.e "Software engineer" or whatever title you want to have.