Closed luiscoms closed 1 year ago
@ashald Borys, that's not fair. I have a fair share of contributions to OSS - Liquibase, openapi-generator. I am in a position where my free time is extremely limited. I think that given my free time I gave back to the community.
I only took a quick look at this repo and saw open PRs from 2020. It really felt neglected. I know this plugin is fully OSS, but I did not feel it would be right that anyone ports Hassan's solution back upstream, even more so as the probability of you approving the PR seemed so small.
@RockyMM
I am in a position where my free time is extremely limited.
For all we know @ashald's time is even more limited than yours and they have already expressed the fact that they are not being supported as much as they need to be financially by the users of this plugin [myself included], couple that with the fact that this is OSS, it's par for the course imo for an OSS repo to sometimes feel abandoned.
To be clear, I didn't mean to pick on anyone personally - apologies if that was an impression.
What I'm saying is that when I see a person with exclusive background in e.g. Python commenting on the issue like this, I have no questions whatsoever as they simply may lack expertise in Java to contribute a fix. When I see a person with lots of repos in Java, I'd imagine nothing really stops them from trying to debug an issue on their own. Well, except the lack of time or real interest in that thing working.
And I must be fair: I did have few contributions when people saw things broken and submitted a PR to fix them, but I'm wondering about that fuzzy state in which "it's annoying enough to comment on a ticket, but not annoying enough to contribute a fix despite having relevant expertise."
FWIW, I pushed fixes into the develop branch. I plan to include few extra small fixes and release a new version coming week. Stay tuned.
Glad to see things are still picking up steam here! I've gone ahead and added notices to my fork telling people to head back here. If you had installed one of my releases, and would like to go back, just uninstall, and reinstall directly from the plugin marketplace once it's available there.
Lol, was just about to open a pull request with fixes for Idea and PyCharm... oh well, learned a lot about JetBrains plugins 😆
@mrworkman what did you plan to fix for IDEA? I was under impressions it works fine.
OK, whatever, cut a new release https://github.com/ashald/EnvFile/releases/tag/v3.3.0
Going to submit it to JetBrains later tonight.
Going to resolve this issue, but if you find any bugs etc - feel free to reopen or create a new issue.
@mrworkman what did you plan to fix for IDEA? I was under impressions it works fine.
EnvFile didn't work for me in IntelliJ 2022.2.2 until I updated to a more recent SDK and updated the method signature.
@mrworkman it doesn't work in my environment, Build #IU-222.4345.14, built on October 5, 2022
What do you mean by updated the method signature
?
Thanks
same here: Intellij Idea Build #IU-222.4345.14, built on October 5, 2022
, doesn't load the .env file with plugin version 3.4.1
. /cc @ashald
same here. Is there any version/fork of envfile that is known to work in Pycharm 2022.2.3?
@trondhindenes I guess we need to create a new issue with reference to this one to move people to reopen this isse.
Just checked and works like a charm in PyCharm 2022.2.4
I got it working. The error was that I tried to use envfile with Pycharm's test runner, and that doesn't work. However regular run configurations do. :shrug:
IntelliJ IDEA 2022.2.3 (Ultimate Edition) Build #IU-222.4345.14, built on October 5, 2022 Runtime version: 17.0.4.1+7-b469.62 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Windows 10 10.0
I have the same problem with Cucumber Java Run/Debug configuration. But running tests with Maven works good.
I am getting empty environment variables on Python projects even I set a value after IntelliJ Update