search

ashald / EnvFile

EnvFile 3.x is a plugin for JetBrains IDEs that allows you to set environment variables for your run configurations from one or multiple files.
MIT License
545 stars 129 forks source link

Add Maven support based on existing Gradle support. #199

Closed markvr closed 1 year ago

markvr commented 1 year ago

Have essentially copy and pasted from existing Gradle support.

Did try to pull common code into an abstract ExecutionEnvironmentProvider class but because MavenExecutionEnvironmentProvider and GradleExecutionEnvironmentProvider don't inherit from a common superclass it just ended up being messy and worse than just having the classes separate.

One thing I noted in testing is that this (and so presumably the Gradle support) works without needing the "Enable experimental features" checkbox enabled.

markvr commented 1 year ago

hi, does this look ok? Can it be merged? :)

ashald commented 1 year ago

Thanks!

One thing I noted in testing is that this (and so presumably the Gradle support) works without needing the "Enable experimental features" checkbox enabled.

I wish I recalled why I added that... Maybe it's time to drop that option. 🤔