ashander / ftprime

Forward-time simulation of the msprime data structure (for development)
2 stars 1 forks source link

Simpler config to avoid upload of coverage w/ failing test #28

Closed ashander closed 7 years ago

ashander commented 7 years ago

removes the env vars set in 17f2ab57b346825b2d482d1892eaabdd2e587af4 (these were originally introduced to ensure uploading of coverage with failed tests, which I now want to avoid)

codecov[bot] commented 7 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files           3        3           
  Lines         158      158           
=======================================
  Hits          157      157           
  Misses          1        1
Flag Coverage Δ
#unit 63.92% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17f2ab5...2e31f99. Read the comment docs.

ashander commented 7 years ago

will merge this. if we don't like its behavior can revert to https://github.com/ashander/ftprime/commit/17f2ab57b346825b2d482d1892eaabdd2e587af4