search

ashang / gitiles

Automatically exported from code.google.com/p/gitiles
0 stars 0 forks source link

Feature request: make json format of revisions range log in googlesource also return changed files #59

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Currently for the googlesource, the JSON format of the revisions log do not 
contain changed files for each revision(example url: 
https://chromium.googlesource.com/chromium/blink/+log/aac4db20a9205a28a0e2c6fcc4
9b62f937cd8917..f4b446fefad1945ea6dbd789fa0dd15a12f7742f?format=json). Is it 
possible to have each revision also include what files have changed and what 
actions were taken for each of the file (deleted, modified, added)?

Original issue reported on code.google.com by j...@google.com on 28 Jul 2014 at 9:18

GoogleCodeExporter commented 8 years ago 
On the same note, the JSON object returns revisions in (start_range, 
end_range]. Is it possible to also include the start_range revision in the 
webpage/json? For example, the above link will return object that excludes 
revision aac4db20a9205a28a0e2c6fcc49b62f937cd8917

Original comment by j...@chromium.org on 30 Jul 2014 at 6:43

GoogleCodeExporter commented 8 years ago 
For html format, with "pretty=fuller", changed files are shown in the page.
https://chromium.googlesource.com/chromium/blink/+log/aac4db20a9205a28a0e2c6fcc4
9b62f937cd8917..f4b446fefad1945ea6dbd789fa0dd15a12f7742f?pretty=fuller

For json format, with "pretty=fuller&format=json", changed files (including 
change type: delete/modify/add/rename/copy/etc) are not returned.
https://chromium.googlesource.com/chromium/blink/+log/aac4db20a9205a28a0e2c6fcc4
9b62f937cd8917..f4b446fefad1945ea6dbd789fa0dd15a12f7742f?pretty=fuller&format=js
on

Is it possible to have the parity for json format when pretty=fuller is 
specified?

Original comment by st...@chromium.org on 5 Jun 2015 at 11:22

GoogleCodeExporter commented 8 years ago 
With "^", 
https://chromium.googlesource.com/chromium/blink/+/aac4db20a9205a28a0e2c6fcc49b6
2f937cd8917^ returns the previous revision 
e7e3df29e146249efe62e5b6a1f3f2ce0b2358cf (of 
aac4db20a9205a28a0e2c6fcc49b62f937cd8917).

However, 
https://chromium.googlesource.com/chromium/blink/+log/aac4db20a9205a28a0e2c6fcc4
9b62f937cd8917^..f4b446fefad1945ea6dbd789fa0dd15a12f7742f?pretty=fuller doesn't 
include e7e3df29e146249efe62e5b6a1f3f2ce0b2358cf.

Could we also have the parity for /+log/ as /+/?

Original comment by st...@chromium.org on 5 Jun 2015 at 11:27

GoogleCodeExporter commented 8 years ago 
stgao: We're probably not going to do that. Chromium uses their own custom Soy 
template for the HTML view of pretty=fuller, because they really wanted to have 
changed files in that output. I told them it would have to be a custom template 
and not the default because the default is intended to match the output of "git 
log --pretty=fuller", which does not include changed files. The HTML view is 
inherently more customizable than the JSON view.

That said there should at least be parity in the sense that you should be able 
to get this information over JSON _somehow_.

Original comment by dborowitz@google.com on 5 Jun 2015 at 11:42