ashapangare / oauthconsumer

Automatically exported from code.google.com/p/oauthconsumer
0 stars 0 forks source link

Some sub-delims aren't URLEncoded in OAuth Parameters #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
- Send an OAuth request that has a parameter with a RFC 3986 sub-delim in
it (for example, '!').

What is the expected output? What do you see instead?
- Sub-delim should be escaped in SignatureBaseString, but it's not. Simple
fix is to add all sub-delims to the list of characters to encode in
NSString+URLEncoding.m encodeURLParameterString: on line 44. The list of
sub-delims is available at http://tools.ietf.org/html/rfc3986#section-2.2.
I'm using CFSTR(":/=,!$&'()*+;[]@#?").

Original issue reported on code.google.com by mjmal...@gmail.com on 6 Jun 2008 at 9:04

GoogleCodeExporter commented 8 years ago

Original comment by jon.r.cr...@gmail.com on 22 Jul 2008 at 7:17

GoogleCodeExporter commented 8 years ago
Patch committed. Thanks, Mike!

Original comment by jon.r.cr...@gmail.com on 7 Oct 2008 at 7:53