search

ashatat / e-commerce

Basic e-commerce website to practice our gitflow, teamwork, communication and clean code best practices.
MIT License
3 stars 1 forks source link

spike: config.env #22

Open FarahZaqout opened 6 years ago

FarahZaqout commented 6 years ago

This is a decent read about the env files. I think it's time we try using the dotenv rather than env2 and see how it's different.

The main question:

do we make one config file in the root and use it globally across the project or do we make 2 config files one in express and another in react since we are treating them as two separate apps? and if we go for option 2, do we need a third config file for the heroku deployment?

FarahZaqout commented 6 years ago

Using dotenv, and different config.env in different sides (client and server). Do you guys agree? @ashatat @amusameh @ishak52 @RamyAlshurafa

amusameh commented 6 years ago

yeah, I agree. I like the idea of using a config.js file with the .env file to be able to use objects as in the article.