search

ashatat / e-commerce

Basic e-commerce website to practice our gitflow, teamwork, communication and clean code best practices.
MIT License
3 stars 1 forks source link

React server #27

Closed FarahZaqout closed 6 years ago

FarahZaqout commented 6 years ago

create react server with create-react-app

26

amusameh commented 6 years ago

@FarahZaqout Why using .jsx while create-react-app uses .js??

The distinction between .js and .jsx files was useful before Babel, but it’s not that useful anymore. Dan Abramov

you can read his comment is these issues https://github.com/facebook/create-react-app/issues/87#issuecomment-234627904 https://github.com/airbnb/javascript/pull/985

FarahZaqout commented 6 years ago

@FarahZaqout Why using .jsx while create-react-app uses .js??

The distinction between .js and .jsx files was useful before Babel, but it’s not that useful anymore. Dan Abramov

you can read his comment is these issues facebook/create-react-app#87 (comment) airbnb/javascript#985

Yeah, a lot of people are pushing towards this. However, for some reason airbnb refuses to buckle. I have read the issues you linked before and the ones advocating for .js sound more reasonable. However, I would be lying to say that I know for sure what advantages and disadvantages that entails.

FarahZaqout commented 6 years ago

Maybe I should just disable the rule in eslint?