ashatat / e-commerce

Basic e-commerce website to practice our gitflow, teamwork, communication and clean code best practices.

MIT License

3 stars 1 forks source link

create reusable input field. #31

Open FarahZaqout opened 6 years ago

FarahZaqout commented 6 years ago

Input field component:

The component should be usable across the website. For that, it needs to take different types, different classes, and different placeholders, values and names.

Acceptance criteria:

[ ] sufficiently tested.
[x] props are validated.
[x] props include type, class, placeholder, value, and name.
[x] component should be stateless function.

relates #32

FarahZaqout commented 6 years ago

day1: finalized all the required input props with validation

Stopped working yesterday and today to fix urgent issues with Travis, along with @amusameh and @ashatat.

What remains is to make sure it's well tested. Will resume working on it later today (jest tests).

FarahZaqout commented 6 years ago

Component should be ready for review by the end of tomorrow at most.

FarahZaqout commented 6 years ago

Must read jest and use it on another independent repo.