ashatat / e-commerce

Basic e-commerce website to practice our gitflow, teamwork, communication and clean code best practices.
MIT License
3 stars 1 forks source link

Build Login and Sign Up Views #9

Open ashatat opened 6 years ago

ashatat commented 6 years ago

Login:

The login page should include the following components:

Events:

End Point: /login

Method: GET

Success response:

Error response:

Method: POST

Validation required: username, passowrd Permission requirement(auth): none. Success response:

Events:

End Point: /sign-up

Method: GET (will be reassigned to react router later).

Success response:

Error response:

Method: POST

request object (no OAuth) includes:

Validation required:

Permission requirement(auth): none. Success response:

ashatat commented 6 years ago

I am not sure about the HTML GET /login endpoints here, the way I see it they are just routes in the react app? I mean we should have one endpoint / that load the react app then everything will be done inside the react router?

FarahZaqout commented 6 years ago

That is true. Too much non-react work got into my head. Will keep it in mind.

I think it's good to have the endpoints here for now, and then we will have an epic react-router issue that will include all of them.

Also whenever we are fetching things from the backend, we will still have to do a get/post/put...etc request.

What do you think?

ashatat commented 6 years ago

yeah I think you're right when we write the detailed issues it'll make more sense, I guess