search

ashawkey / cubvh

CUDA Mesh BVH tools.
MIT License
156 stars 11 forks source link

Bug in setup.py #5

Open Khrylx opened 1 year ago

Khrylx commented 1 year ago

https://github.com/ashawkey/cubvh/blob/main/setup.py#L39 This line will miss Eigen when the versions contain 0, for example, Eigen 3.4.0.

ashawkey commented 1 year ago

@Khrylx Hi, do you have any suggestion to fix it? I remember to copy this part of code from here.

Khrylx commented 1 year ago

Hi, I suggest changing that line to:

if world_ver is None or major_ver is None or minor_ver is None:
ashawkey commented 1 year ago

thanks! I have fixed it in https://github.com/ashawkey/cubvh/commit/09648cf6c3a0b1b0a6f5a6e525d49ec387a3c99d