search

ashawkey / diff-gaussian-rasterization

Other
347 stars 32 forks source link

Bug in depth backward #4

Closed yihua7 closed 1 year ago

yihua7 commented 1 year ago

There exists a bug of lacking a parentheses here, referring to the issue. The backward of depth estimation may encounter CUDA error based on the current codes.

ashawkey commented 1 year ago

@yihua7 Thanks for spotting this! I have fixed it in https://github.com/ashawkey/diff-gaussian-rasterization/commit/d2109176d15619b2efcb4741bcf672bedba84fb2.

yihua7 commented 1 year ago

Sure :) By the way, I really appreciate your excellent projects. Based on torch-ngp I developed my SIGGRAPH paper NeRF-Texture. I have acknowledged it on the website. Looking forward to your future works and learning more from you :)

ashawkey commented 1 year ago

Nice work! Thanks!