search

ashb / windows-fonts

Python access to Windows Font catalog
MIT License
2 stars 0 forks source link

Add support for finding FontVariants by "full name" directly. #9

Closed ashb closed 1 year ago

ashb commented 1 year ago

There are other "properties" that could be added to this function(weight, style, etc) but I haven't added them at this point.

Closes #6

ashb commented 1 year ago

@moi15moi would this give you what you asked for in #6?

codecov[bot] commented 1 year ago

Codecov Report

Base: 82.03% // Head: 87.93% // Increases project coverage by +5.90% :tada:

Coverage data is based on head (3635a6b) compared to base (5c393c5). Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9 +/- ## ========================================== + Coverage 82.03% 87.93% +5.90% ========================================== Files 3 3 Lines 423 605 +182 ========================================== + Hits 347 532 +185 + Misses 76 73 -3 ``` | [Impacted Files](https://codecov.io/gh/ashb/windows-fonts/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ash+Berlin-Taylor) | Coverage Δ | | |---|---|---| | [src/errors.rs](https://codecov.io/gh/ashb/windows-fonts/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ash+Berlin-Taylor#diff-c3JjL2Vycm9ycy5ycw==) | `0.00% <0.00%> (ø)` | | | [src/lib.rs](https://codecov.io/gh/ashb/windows-fonts/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ash+Berlin-Taylor#diff-c3JjL2xpYi5ycw==) | `89.59% <97.23%> (+6.66%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ash+Berlin-Taylor). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ash+Berlin-Taylor)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

moi15moi commented 1 year ago

Yes. I did not test it, but overall, it seems to do what I wanted

ashb commented 1 year ago

~I'll release this as 1.0.0 (non-pre release) tomorrow.~ Done.