search

ashblue / fluid-behavior-tree

Behavior trees for Unity3D projects. Written with a code driven approach on the builder pattern.
MIT License
967 stars 110 forks source link

fix(conditions): generic condition had exit and init reversed #54

Closed hookSSi closed 3 years ago

hookSSi commented 3 years ago

Didn't seem to cause any problems. But would have definitely caused issues with extending the ConditionGeneric class.

hookSSi commented 3 years ago

I wrote a PR according to the guidelines.

This is my first experience, so I don't know if I did well.

By all means, I would like you to share your opinion with a beginner like me.

ashblue commented 3 years ago

@hookSSi this looks solid. I'll pull down the code and verify everything this weekend (would sooner but my job has been a bit crazy this week with a huge upcoming release).

I think the test needs to be adjusted slightly to prevent a potential regression. It should be pretty easy to adjust.

ashblue commented 3 years ago

@all-contributors please add @hookSSi for code

allcontributors[bot] commented 3 years ago

@ashblue

I've put up a pull request to add @hookSSi! :tada:

hookSSi commented 3 years ago

@ashblue

I'm so sorry for that.

Thank you for your kind and detailed explanation even in the midst of a busy time.

Finally, what I hit wrong "Merge branch'develop' into feature/condition-generic-exit-init-bug" was made.

Hope this doesn't make you uncomfortable.

ashblue commented 3 years ago

@hookSSi I double checked everything and it all looks great 👍 Feel free to merge.