search

ashchan / mail-notifr

Mail Notifr - Gmail Notifier for macOS
https://ashchan.com/projects/gmail-notifr
MIT License
210 stars 35 forks source link

Menu bar icon is slightly lower than it should be #59

Closed taras-mukin closed 3 years ago

taras-mukin commented 3 years ago

Right now it's not vertically centered correctly, sitting slightly below all other icons and text in the menu bar. Most visible with unread mail count next to it, or compared with similarly shaped icon.

image
ashchan commented 3 years ago

@taras-mukin Thanks for bringing this up. This is indeed a problem. I'll see if we can move it above 1 or 2 pixels.

ashchan commented 3 years ago

Position after the pending changes:

CleanShot 2021-11-21 at 17 02 26@2x

@taras-mukin Does this look a bit better?

taras-mukin commented 3 years ago

@taras-mukin Does this look a bit better?

Looks perfect to me, thanks! (I actually tried moving things around in editor, and none of the icons actually line up pixel-by-pixel with each other or with other text, so it's just eyeballing at this point, and this new position looks the best)

ashchan commented 3 years ago

Yes apps have variant sizes of icons. But it was my problem not aligning the number with the icon properly. I remember on a previous MacOS version they did align better.

Merging this. I'll release when I have other issues solved.