search

ashdavies / rx-tasks

Simple and lightweight RxJava2 wrapper for the GMS Tasks API
Apache License 2.0
65 stars 15 forks source link

Is the Kotlin Scripting JVM dependency actually needed? #26

Open arekolek opened 3 years ago

arekolek commented 3 years ago

I'm wondering what is the 'org.jetbrains.kotlin:kotlin-scripting-jvm:1.3.11' dependency used for and do I need it on my runtime classpath when I use this library.

I downloaded this repository, commented out that dependency and ran ./gradlew clean assemble and build succeeded, so maybe it's not needed?

Edit: also executed all the tests and they ran fine.

It pulls in dependencies with known security vulnerabilities, which I'd prefer to avoid: https://nvd.nist.gov/vuln/search/results?form_type=Advanced&results_type=overview&search_type=all&cpe_vendor=cpe%3A%2F%3Ajetbrains&cpe_product=cpe%3A%2F%3Ajetbrains%3Akotlin

ubuntudroid commented 1 year ago

They should not be necessary from what I see. You can exclude them via

implementation('io.ashdavies.rx.rxtasks:rx-tasks:2.2.0') {
    exclude group: 'org.jetbrains.kotlin', module: 'kotlin-scripting-jvm'
}