ashdnazg / pyreshark

A Wireshark plugin providing a simple interface for writing dissectors in Python.
https://github.com/ashdnazg/pyreshark/releases/tag/0.1.4
170 stars 33 forks source link

Weird set_next_dissector behavior? #24

Closed ijs6 closed 5 years ago

ijs6 commented 5 years ago

I might be overlooking something extremely simple... but I'm having some trouble setting the next dissector when passing a variable representing a string to the set_next_dissector() function, rather than a string itself. For instance:

self.set_next_dissector('protocol') works, while

self.set_next_dissector(protocol_name) does not, even if protocol_name == 'protocol' .

ijs6 commented 5 years ago

Other than this I have had zero problems getting dissectors to work properly.

ijs6 commented 5 years ago

Fixed. There was an error in a a dissector being called later in the chain which I believe was preventing proper function

ashdnazg commented 5 years ago

Good job :)