search

ashenchowthee / zaproxy

Automatically exported from code.google.com/p/zaproxy
0 stars 0 forks source link

TestExternalRedirect Plugin ID issue #1569

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
TestExternalRedirect.java uses plugin id 30000, however 
https://code.google.com/p/zaproxy/source/browse/trunk/src/doc/alerts.xml states 
that the 30Ks are for "30000 - 39999 for likely harmful check such as buffer 
overflow"[1], external redirect isn't harmful from an app perspective.

Assign new plugin ID.

[1] https://code.google.com/p/zaproxy/source/browse/trunk/src/doc/alerts.xml#30

Original issue reported on code.google.com by kingtho...@gmail.com on 18 Mar 2015 at 5:11

GoogleCodeExporter commented 9 years ago 
https://code.google.com/p/zaproxy/source/browse/trunk/src/doc/alerts.xml#107

Original comment by kingtho...@gmail.com on 18 Mar 2015 at 5:11

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
r5936 r5937
https://code.google.com/p/zap-extensions/source/detail?r=1970

Original comment by kingtho...@gmail.com on 21 Mar 2015 at 12:24

GoogleCodeExporter commented 9 years ago 
This change breaks the ZAP API clients that are using the ID to 
enable/disable/configure the scanner.

Original comment by THC...@gmail.com on 21 Mar 2015 at 12:36

GoogleCodeExporter commented 9 years ago 
Ok I don't mind reverting it, though it doesn't align with the outline of
numbering in alerts.xml.

I'll guess I'll restore it as 30k and add a comment to the xml file?

Then there isn't any breaking disablePlugin(30000) (er whatever).....that
someone might already have setup.

Original comment by kingtho...@gmail.com on 21 Mar 2015 at 3:15

GoogleCodeExporter commented 9 years ago 
Maybe it's enough to document the change in the release notes?

Original comment by THC...@gmail.com on 21 Mar 2015 at 3:37

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
That makes sense. I'll make sure it hits release notes, add-on manifest, and 
release blog post.

Original comment by kingtho...@gmail.com on 22 Mar 2015 at 11:55

GoogleCodeExporter commented 9 years ago 
r5948 r5949

Original comment by kingtho...@gmail.com on 25 Mar 2015 at 4:52

GoogleCodeExporter commented 9 years ago 
https://code.google.com/p/zap-extensions/source/detail?r=1987

Original comment by kingtho...@gmail.com on 1 Apr 2015 at 11:54

GoogleCodeExporter commented 9 years ago 
Fixed in 2.4.0

Original comment by psii...@gmail.com on 14 Apr 2015 at 11:03