search

asherbender / bayesian-linear-model

Bayesian Linear Model
Apache License 2.0
5 stars 1 forks source link

Fixing deprecated `inner1d` using `np.dot` (for python3) #2

Closed glandfried closed 9 months ago

glandfried commented 1 year ago

Hi @asherbender ,

While I have implemented my own Bayesian linear regression, I found your solution to be neater, so I generally use it.

You may be interested to know that the inner1d function has already been deprecated. In this PR I simply replace the functionality of inner1d by np.dot().

This version was tested in Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux

Kind regards

asherbender commented 9 months ago

Gustavo,

SORRY for the long, long (long) delay. I really appreciate the contribution. Great point - clearly I havent fired up this code for nearly 10 years!

I should modernise it (type hints etc).

Again! Thank you so much. I am glad the code has a broader audience :smile: