asherhy / pe

0 stars 0 forks source link

Unreasonable dates are allowed which should not be the case #1

Open asherhy opened 2 years ago

asherhy commented 2 years ago

Here the date would mean this person is over 2 thousand years old

Screenshot 2021-11-12 at 4.18.34 PM.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Participants with near impossible birth dates allowed to be added

Description Participants with impossible birth dates are allowed to be added with no warning or error. Such entries are likely to be accidental and incorrect, and users should be informed of errant entries like these that would affect the accuracy of their data.

Steps to Reproduce

  1. Enter command add n/ABC p/999 e/abc@abc.com a/Blk 999 Police Station d/1800-06-22

Expected Outcome User should be warned that birthdate is unlikely to be accurate.

Actual Outcome Participant born in year 1800 reflected in the list of participants.

image.png


[original: nus-cs2103-AY2122S1/pe-interim#4597] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We can't rule out this possibility. To be fair, we can't fix a exact cut off birthdate for the oldest possible participant.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: There should be an attempt to limit the age. Even if the team cannot fix an exact cut off, 150 years back from today's date might be fine too as the oldest person in the world lived to 122 years old. As shown, facebook and many other websites/applications will attempt to limit what the user can choose as their age, being able to indicate 2000 years old is simply not logical to have in the application.

Screenshot 2021-11-18 at 7.32.56 PM.png


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]