rename thrust::iterator_space

[GoogleCodeExporter]

i propose

thrust::iterator_space -> thrust::iterator_system

we can deprecate the old name

Iterator parameters named Tag could be lazily renamed to something like 
SystemTag or just System

Original issue reported on code.google.com by jaredhoberock on 23 Jan 2012 at 11:23

[GoogleCodeExporter]

If we rename thrust::iterator_space to thrust::iterator_system

Should we also rename thrust::device_space_tag to thrust::device_system_tag and 
similarly for thrust::host_system_tag and thrust::any_system_tag? (We'd 
deprecate the old names with a warning)

We should use consistent language throughout, but these particular changes 
might be irritating.

Original comment by jaredhoberock on 2 Feb 2012 at 11:56

[GoogleCodeExporter]

Could we provide a find and replace script for this and post it to the ml?

(it would also save me the effort of doing this by hand :)

Original comment by jaredhoberock on 4 Feb 2012 at 12:32

[GoogleCodeExporter]

I can do this

Original comment by wnbell on 4 Feb 2012 at 4:42

[GoogleCodeExporter]

We need to deprecate iterator_space in a particular way to make the warning 
show up

Original comment by jaredhoberock on 4 Feb 2012 at 4:44

[GoogleCodeExporter]

To recap:

Introduce thrust::host_system_tag, thrust::device_system_tag, and 
thrust::any_system_tag with the old tags' implementations.

thrust::host_space_tag becomes:

typedef THRUST_DEPRECATED host_system_tag host_space_tag;

Similarly for the other two tags.

thrust::iterator_system gets thrust::iterator_space's old implementation.

thrust::iterator_space becomes:

template<typename Iterator>
  struct iterator_space
{
  typedef THRUST_DEPRECATED typename iterator_system<Iterator>::type type;
} THRUST_DEPRECATED;

iterator_space needs two deprecateds: once for iterator_space as a whole, and 
once for the nested typedef.

Original comment by jaredhoberock on 4 Feb 2012 at 7:02

[GoogleCodeExporter]

This issue was closed by revision 18d60d15defb.

Original comment by wnbell on 10 Feb 2012 at 5:14

• Changed state: Fixed