search

asheroto / winget-install

Install winget tool using PowerShell! Prerequisites automatically installed. Works on Windows 10/11 and Server 2019/2022.
https://bit.ly/winget-install
GNU General Public License v3.0
272 stars 33 forks source link

Fix very tiny comment-code mismatch #37

Closed og-mrk closed 7 months ago

og-mrk commented 7 months ago

Commit body message

The comment states that it'll wait 5 seconds before starting to check if winget is installed and works successfully, but the actual code waits for 3 seconds not 5

Some Notes

I know it isn't very important, but just wanted to point it out. And it could be on purpose, in this case my apologies for wasting your time on this useless pr, and have a nice day.

Also, I really like what you've done, and I use your script.. let's say "indirectly" with Christitus's WinUtil PowerShell script, both scripts/projects are amazing! I enjoy using both as well as contributing when I can 😄

og-mrk commented 7 months ago

Agree, makes future maintenance of comment-code "syncing" a lot more easier. For this comment, it'll be more accurate to state "Timeout before checking winget", because this is what the code does, it times-out a bit, then checks to see if winget has installed successfully.

Will push the updated changes accordingly... And if you have any further notes, feel free to post them, and I'll reply as soon as I can 👍

asheroto commented 7 months ago

Looks great, thanks again!

og-mrk commented 7 months ago

No problem, glad I could help