asheshrambachan / HonestDiD

Robust inference in difference-in-differences and event study designs
Other
175 stars 45 forks source link

HonestDiD::createSensitivityPlot_relativeMagnitudes and unused filter #20

Closed dschwartzman closed 1 year ago

dschwartzman commented 1 year ago

Thank you for both the theoretical contributions and the package!

I am having an issue with the createSensitivityPlot_relativeMagnitudes and createSensitivityPlot functions.

I am able to produce delta_rm_results and originalResults normally. However, when I do the following command:

HonestDiD::createSensitivityPlot_relativeMagnitudes(delta_rm_results, originalResults)

I get the error message:

Error in filter(., Mbar <= maxMbar) : unused argument (Mbar <= maxMbar)

Any guidance on this kind of issue? I was able to use the command without issue for about half a day and then this error appeared. I have tried re-loading the environment and re-installing the package.

jonathandroth commented 1 year ago

Hi,

Thanks very much for your email! It looks to me like in the createSensitivityPlot_relativeMagnitudes(), the call to the filter() function did not explicitly say dplyr::filter(). My guess is that this worked for you until you loaded a different package with a filter() function that behaves differently from the dplyr one. I have just pushed an update that makes explicit the dplyr call. Can you reinstall the package from github, restart R, and let me know if that works?

@Ashesh Rambachan @.***> we (or an RA) should go through the package and make sure that all function calls are explicit about the package.

Best, Jon

On Wed, Feb 1, 2023 at 10:52 AM dschwartzman @.***> wrote:

Thank you for both the theoretical contributions and the package!

I am having an issue with the createSensitivityPlot_relativeMagnitudes and createSensitivityPlot functions.

I am able to produce delta_rm_results and originalResults normally. However, when I do the following command:

HonestDiD::createSensitivityPlot_relativeMagnitudes(delta_rm_results, originalResults)

I get the error message:

Error in filter(., Mbar <= maxMbar) : unused argument (Mbar <= maxMbar)

Any guidance on this kind of issue? I was able to use the command without issue for about half a day and then this error appeared. I have tried re-loading the environment and re-installing the package.

— Reply to this email directly, view it on GitHub https://github.com/asheshrambachan/HonestDiD/issues/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE6EXFB4QTG2JZVDK56XOQDWVKBC7ANCNFSM6AAAAAAUN4VGQI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dschwartzman commented 1 year ago

Yes, this resolved the issue. Thank you for your help!

jonathandroth commented 1 year ago

Glad to hear!

On Wed, Feb 1, 2023, 2:59 PM dschwartzman @.***> wrote:

Yes, this resolved the issue. Thank you for your help!

— Reply to this email directly, view it on GitHub https://github.com/asheshrambachan/HonestDiD/issues/20#issuecomment-1412643968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE6EXFHGA4PWRNM5QYDLGADWVK6ANANCNFSM6AAAAAAUN4VGQI . You are receiving this because you commented.Message ID: @.***>

mcaceresb commented 1 year ago

@jonathandroth FYI #22 should also allow closing this issue.