search

asheshrambachan / HonestDiD

Robust inference in difference-in-differences and event study designs
Other
175 stars 45 forks source link

Pull Request: Add Sun and Abraham Example #55

Closed mcaceresb closed 7 months ago

mcaceresb commented 8 months ago

Adds a sub-section for Sun and Abraham to the Staggered Timing section in the README, based on the function proposed in this comment in lrberge/fixest/issues/295.

@jonathandroth LMK if this works. I believe you can see it rendered from my branch here.

jonathandroth commented 7 months ago

Thanks, Mauricio! Overall, this looks great.

The one thing that jumps out to me is that I think you're using the default dataset provided by fixest as an example, whereas all the other examples on the README page use the Medicaid data example. Can we either:

(A) re-do the sunab call using the Medicaid data, or (B) mention that we're using the example data from fixest

I think (A) is preferable, but if there's some reason it's difficult to do, then let's do (B).

On Mon, Mar 18, 2024 at 9:54 PM Mauricio Caceres Bravo < @.***> wrote:

Adds a sub-section for Sun and Abraham to the Staggered Timing section in the README, based on the function proposed in this comment https://github.com/lrberge/fixest/issues/295#issuecomment-1973844111 in lrberge/fixest/issues/295 https://github.com/lrberge/fixest/issues/295.

@jonathandroth https://github.com/jonathandroth LMK if this works. I believe you can see it rendered from my branch here https://github.com/mcaceresb/HonestDiD/tree/issue_sunab_example.

You can view, comment on, or merge this pull request online at:

https://github.com/asheshrambachan/HonestDiD/pull/55 Commit Summary

File Changes

(42 files https://github.com/asheshrambachan/HonestDiD/pull/55/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/asheshrambachan/HonestDiD/pull/55, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE6EXFE2MYQOZ5B6HTSHZR3YY6LFTAVCNFSM6AAAAABE4VFC5SVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TGOBUGI3DINY . You are receiving this because you were mentioned.Message ID: @.***>

mcaceresb commented 7 months ago

@jonathandroth Just swapping out the data is straightforward, though including the older periods for the 2017/2019 cohorts blows up the HonestDiD CIs. Anyway, see update in my branch. (Here.)

jonathandroth commented 7 months ago

This seems good - thanks!

One Q: do you think the checks following "# Check the coefs and diagonal" are necessary for folks to run? Might be simpler to delete those lines in the ex if it's not necessary?

On Wed, Mar 27, 2024 at 5:03 PM Mauricio Caceres Bravo < @.***> wrote:

@jonathandroth https://github.com/jonathandroth Just swapping out the data is straightforward, though including the older periods for the 2017/2019 cohorts blows up the HonestDiD CIs. Anyway, see update in my branch. (Here https://github.com/mcaceresb/HonestDiD/tree/0b26a20879768c479b2e3d6e242196941889588a?tab=readme-ov-file#sun-and-abraham .)

— Reply to this email directly, view it on GitHub https://github.com/asheshrambachan/HonestDiD/pull/55#issuecomment-2023986006, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE6EXFGML4BME5C7IRTMEM3Y2MXZXAVCNFSM6AAAAABE4VFC5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRTHE4DMMBQGY . You are receiving this because you were mentioned.Message ID: @.***>