Closed mcaceresb closed 6 months ago
@jonathandroth Can you test the function on your mac? The tests are failing for OSX but not for Linux somehow. Just wanna double-check there isn't an issue. LMK and I'll merge.
I ran test_base.R (I assume that's what you wanted?) and I get the following error:
── Error (~/Library/CloudStorage/Dropbox/HonestDiD_MauricioGithub/HonestDiD/tests/test_base.R:28:5): HonestDiD base ran with no errors ──
Error in { temp = computeConditionalCS_DeltaSD(betahat = betahat, sigma = sigma, numPrePeriods = numPrePeriods, numPostPeriods = numPostPeriods, l_vec = l_vec, alpha = alpha, M = Mvec[m], hybrid_flag = "ARP") tibble::tibble(lb = base::min(temp$grid[temp$accept == 1]), ub = base::max(temp$grid[temp$accept == 1]), method = "Conditional", Delta = "DeltaSD", M = Mvec[m]) }
: task 2 failed - "ℹ In index: 763.
Caused by error in if (sigma_B_dual < 10^(-10)) ...
:
! missing value where TRUE/FALSE needed"
Backtrace:
▆
Error in reporter$stop_if_needed() : Test failed
@jonathandroth Ok this is fixed. It seems sometimes it overflowed into a numerical zero but it was negative, so sqrt
failed. I've accounted for this. I'll merge.
This addresses the comments here that the computing time for the examples, tests, and vignette are too long.
dontrun
do they don't run, cutting the runtime.HONESTDID_RUN_TESTS=1
is set, as suggested.vignette/precompute.R
script has all the vignette code and should be updated and re-run if the vignette ever changes. However, it's not included in the package build (see.Rbuildignore
).